Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2985183002: [vm] Remove Dartium's vm-service implementation. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -199 lines) Patch
D runtime/bin/vmservice_dartium.h View 1 chunk +0 lines, -43 lines 0 comments Download
D runtime/bin/vmservice_dartium.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D runtime/bin/vmserviceio_dartium.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 4 months ago (2017-07-27 01:12:33 UTC) #2
siva
lgtm
3 years, 4 months ago (2017-07-27 01:14:09 UTC) #3
rmacnak
3 years, 4 months ago (2017-07-27 01:22:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c83a6831fcf4b52e2413747fbc91804d17180406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698