Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2985113002: Add dump-partial tool. (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
aam, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dump-partial tool. This script lets you dump as text a partial .dill file generated by the incremental generator. To do so, it requires that you pass in other .dill files that are needed (in order). In the context of a hot-reload test, you should be able to run this as follows: pkg/front_end/tool/fasta dump-ir newProgram.dill fullProgram.dill platform.dill BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/92481e9b34170671d49a62be04837204249cc8a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A pkg/front_end/tool/_fasta/dump_partial.dart View 1 chunk +72 lines, -0 lines 0 comments Download
M pkg/front_end/tool/fasta View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-07-26 21:05:52 UTC) #3
scheglov
lgtm
3 years, 4 months ago (2017-07-26 21:20:44 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as 64adc3c87b942012a6bef0a7927a47b6d80d63e8 (presubmit successful).
3 years, 4 months ago (2017-07-26 22:14:51 UTC) #6
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-07-26 22:19:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
92481e9b34170671d49a62be04837204249cc8a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698