Issue 2985063002: remove redundant type check in DDC's SDK implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2985063002: remove redundant type check in DDC's SDK implementation (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly

Modified:
3 years, 5 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View		Binary file		0 comments	Download
	M	pkg/dev_compiler/tool/input_sdk/private/js_array.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

TBR. Thanks for catching this! This patch was supposed to be included in the previous ...

3 years, 5 months ago (2017-07-26 01:33:01 UTC) #2

Jennifer Messerly

Committed patchset #1 (id:1) manually as f0c8fe6763c432c8383fcd40cc7873a93a6781fd (presubmit successful).

3 years, 5 months ago (2017-07-26 01:33:24 UTC) #4

Message was sent while issue was closed.

LGTM, thanks!