Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: net/ftp/ftp_network_transaction.h

Issue 2985012: FTP: add more detailed error codes based on RFC 959. (Closed)
Patch Set: fixes Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ftp/ftp_network_transaction.h
diff --git a/net/ftp/ftp_network_transaction.h b/net/ftp/ftp_network_transaction.h
index 66724c69cd57d05ff700ded98f692bcd549da2dd..31c38c746c409182ab8dec4921e028bb058b6f35 100644
--- a/net/ftp/ftp_network_transaction.h
+++ b/net/ftp/ftp_network_transaction.h
@@ -63,29 +63,6 @@ class FtpNetworkTransaction : public FtpTransaction {
COMMAND_QUIT,
};
- enum ErrorClass {
- // The requested action was initiated. The client should expect another
- // reply before issuing the next command.
- ERROR_CLASS_INITIATED,
-
- // The requested action has been successfully completed.
- ERROR_CLASS_OK,
-
- // The command has been accepted, but to complete the operation, more
- // information must be sent by the client.
- ERROR_CLASS_INFO_NEEDED,
-
- // The command was not accepted and the requested action did not take place.
- // This condition is temporary, and the client is encouraged to restart the
- // command sequence.
- ERROR_CLASS_TRANSIENT_ERROR,
-
- // The command was not accepted and the requested action did not take place.
- // This condition is rather permanent, and the client is discouraged from
- // repeating the exact request.
- ERROR_CLASS_PERMANENT_ERROR,
- };
-
// Major categories of remote system types, as returned by SYST command.
enum SystemType {
SYSTEM_TYPE_UNKNOWN,
@@ -123,10 +100,6 @@ class FtpNetworkTransaction : public FtpTransaction {
int SendFtpCommand(const std::string& command, Command cmd);
- // Return the error class for given response code. You should validate the
- // code to be in range 100-599.
- static ErrorClass GetErrorClass(int response_code);
-
// Returns request path suitable to be included in an FTP command. If the path
// will be used as a directory, |is_directory| should be true.
std::string GetRequestPathForFtpCommand(bool is_directory) const;

Powered by Google App Engine
This is Rietveld 408576698