Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2984963002: Enable Run step in closure-conversion test suite (Closed)

Created:
3 years, 5 months ago by Dmitry Stefantsov
Modified:
3 years, 5 months ago
Reviewers:
sjindel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M pkg/kernel/test/closures/closures.status View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dmitry Stefantsov
Apparently, running compiled .dill files was fixed recently.
3 years, 5 months ago (2017-07-25 11:02:22 UTC) #2
sjindel
lgtm
3 years, 5 months ago (2017-07-25 12:02:22 UTC) #3
Dmitry Stefantsov
3 years, 5 months ago (2017-07-25 12:03:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08e91e07b77d2dcb5c40a52753717f6d2223a29a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698