chrome/browser/resources/settings/languages_page/add_languages_dialog.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_summary.js ('k') | chrome/browser/resources/settings/languages_page/edit_dictionary_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

index d3fda59dc77784210fd6de0e61a7439767a25fff..d4bc264f1b1b5a47928fa84fe8759b32048183d8 100644

--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js

@@ -65,7 +65,7 @@ Polymer({

getLanguages_: function() {

var filterValue =

this.filterValue_ ? this.filterValue_.toLowerCase() : null;

- return this.languages.supported.filter(function(language) {

+ return this.languages.supported.filter(language => {

var isAvailableLanguage =

!this.languageHelper.isLanguageEnabled(language.code);

@@ -77,7 +77,7 @@ Polymer({

return language.displayName.toLowerCase().includes(filterValue) ||

language.nativeDisplayName.toLowerCase().includes(filterValue);

- }.bind(this));

+ });

/**

@@ -134,8 +134,8 @@ Polymer({

onActionButtonTap_: function() {

this.$.dialog.close();

- this.languagesToAdd_.forEach(function(languageCode) {

+ this.languagesToAdd_.forEach(languageCode => {

this.languageHelper.enableLanguage(languageCode);

- }.bind(this));

+ });

});