chrome/browser/resources/settings/appearance_page/appearance_page.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/animation/animation.js ('k') | chrome/browser/resources/settings/appearance_page/home_url_input.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js

index 8b22e8fe6d82a3f7ef9e1660e582233be9b0e1ad..e8decc01566ded491d96457ba47c16d66b94f595 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js

@@ -140,9 +140,9 @@ Polymer({

this.$.defaultFontSize.menuOptions = this.fontSizeOptions_;

// TODO(dschuyler): Look into adding a listener for the

// default zoom percent.

- this.browserProxy_.getDefaultZoom().then(function(zoom) {

+ this.browserProxy_.getDefaultZoom().then(zoom => {

this.defaultZoom_ = zoom;

- }.bind(this));

+ });

/**

@@ -271,9 +271,9 @@ Polymer({

if (themeId) {

assert(!useSystemTheme);

- this.browserProxy_.getThemeInfo(themeId).then(function(info) {

+ this.browserProxy_.getThemeInfo(themeId).then(info => {

this.themeSublabel_ = info.name;

- }.bind(this));

+ });

this.themeUrl_ = 'https://chrome.google.com/webstore/detail/' + themeId;

return;