chrome/browser/resources/settings/about_page/detailed_build_info.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/about_page/channel_switcher_dialog.js ('k') | chrome/browser/resources/settings/animation/animation.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/detailed_build_info.js

diff --git a/chrome/browser/resources/settings/about_page/detailed_build_info.js b/chrome/browser/resources/settings/about_page/detailed_build_info.js

index 8a5842bf2b867bdd09a29806af9402ee8ae9f2d1..471263b7ec396bfd9886dc60228fbe2b62576304 100644

--- a/chrome/browser/resources/settings/about_page/detailed_build_info.js

+++ b/chrome/browser/resources/settings/about_page/detailed_build_info.js

@@ -31,9 +31,9 @@ Polymer({

var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance();

browserProxy.pageReady();

- browserProxy.getVersionInfo().then(function(versionInfo) {

+ browserProxy.getVersionInfo().then(versionInfo => {

this.versionInfo_ = versionInfo;

- }.bind(this));

+ });

this.updateChannelInfo_();

@@ -41,13 +41,13 @@ Polymer({

/** @private */

updateChannelInfo_: function() {

var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance();

- browserProxy.getChannelInfo().then(function(info) {

+ browserProxy.getChannelInfo().then(info => {

// Display the target channel for the 'Currently on' message.

this.currentlyOnChannelText_ = this.i18n(

'aboutCurrentlyOnChannel',

this.i18n(settings.browserChannelToI18nId(info.targetChannel)));

this.canChangeChannel_ = info.canChangeChannel;

- }.bind(this));

+ });

/**