Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)
Patch Set: Fix compiler errors, newly revealed. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-add-languages-dialog' is a dialog for enabling 6 * @fileoverview 'settings-add-languages-dialog' is a dialog for enabling
7 * languages. 7 * languages.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-add-languages-dialog', 10 is: 'settings-add-languages-dialog',
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 onSearchChanged_: function(e) { 56 onSearchChanged_: function(e) {
57 this.filterValue_ = /** @type {string} */ (e.detail); 57 this.filterValue_ = /** @type {string} */ (e.detail);
58 }, 58 },
59 59
60 /** 60 /**
61 * @return {!Array<!chrome.languageSettingsPrivate.Language>} A list of 61 * @return {!Array<!chrome.languageSettingsPrivate.Language>} A list of
62 * languages to be displayed. 62 * languages to be displayed.
63 * @private 63 * @private
64 */ 64 */
65 getLanguages_: function() { 65 getLanguages_: function() {
66 return this.languages.supported.filter(function(language) { 66 return this.languages.supported.filter(language => {
67 var isAvailableLanguage = 67 var isAvailableLanguage =
68 !this.languageHelper.isLanguageEnabled(language.code); 68 !this.languageHelper.isLanguageEnabled(language.code);
69 69
70 if (!isAvailableLanguage) 70 if (!isAvailableLanguage)
71 return false; 71 return false;
72 72
73 if (!this.filterValue_) 73 if (!this.filterValue_)
74 return isAvailableLanguage; 74 return isAvailableLanguage;
75 75
76 return language.displayName.toLowerCase().includes( 76 return language.displayName.toLowerCase().includes(
77 this.filterValue_.toLowerCase()); 77 this.filterValue_.toLowerCase());
78 }.bind(this)); 78 });
79 }, 79 },
80 80
81 /** 81 /**
82 * @param {!chrome.languageSettingsPrivate.Language} language 82 * @param {!chrome.languageSettingsPrivate.Language} language
83 * @return {string} The text to be displayed. 83 * @return {string} The text to be displayed.
84 * @private 84 * @private
85 */ 85 */
86 getDisplayText_: function(language) { 86 getDisplayText_: function(language) {
87 var displayText = language.displayName; 87 var displayText = language.displayName;
88 // If the native name is different, add it. 88 // If the native name is different, add it.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 onCancelButtonTap_: function() { 125 onCancelButtonTap_: function() {
126 this.$.dialog.close(); 126 this.$.dialog.close();
127 }, 127 },
128 128
129 /** 129 /**
130 * Enables the checked languages. 130 * Enables the checked languages.
131 * @private 131 * @private
132 */ 132 */
133 onActionButtonTap_: function() { 133 onActionButtonTap_: function() {
134 this.$.dialog.close(); 134 this.$.dialog.close();
135 this.languagesToAdd_.forEach(function(languageCode) { 135 this.languagesToAdd_.forEach(languageCode => {
136 this.languageHelper.enableLanguage(languageCode); 136 this.languageHelper.enableLanguage(languageCode);
137 }.bind(this)); 137 });
138 }, 138 },
139 }); 139 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698