appengine/swarming/server/task_scheduler.py - Issue 2984843002: swarming: switch to a 'capability focused' ACL system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/server/task_scheduler.py

Issue 2984843002: swarming: switch to a 'capability focused' ACL system (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/swarming/server/task_scheduler.py

diff --git a/appengine/swarming/server/task_scheduler.py b/appengine/swarming/server/task_scheduler.py

index 5da8fdcbc0a4a327fbb138bbed44f93d0662320a..bfff3d433f5b898a5f1b0d510a50cf935f33c6ad 100644

--- a/appengine/swarming/server/task_scheduler.py

+++ b/appengine/swarming/server/task_scheduler.py

@@ -403,7 +403,8 @@ def _check_dimension_acls(request):

# 'pool' is used as well (so whoever can posts tasks to 'pool', can target an

# individual bot in that pool).

if 'id' in dims and 'pool' not in dims:

- if not acl.is_admin():

+ # Only super-users can create a task without 'id' nor 'pool'.

+ if not acl.can_config_edit():

raise auth.AuthorizationError(

'Only Swarming administrators can post tasks with "id" dimension '

'without specifying a "pool" dimension.')