pkg/front_end/lib/src/fasta/scanner/string_scanner.dart - Issue 2984713002: Fix scanning of unterminated strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

Issue 2984713002: Fix scanning of unterminated strings (Closed)

Patch Set: address comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

diff --git a/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

index 2c90b52e08dc999aabe3e684b3656cac90a80a4a..8e45e86cb0dbe23481e5aeb06883bdfd6106314e 100644

--- a/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

+++ b/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

@@ -60,7 +60,7 @@ class StringScanner extends ArrayBasedScanner {

TokenType type, int start, bool asciiOnly, String closingQuotes) {

String source = string.substring(start, scanOffset);

return new SyntheticStringToken(

- type, source + closingQuotes, start, source.length);

+ type, source + closingQuotes, tokenStart, source.length);

}

@override