Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart

Issue 2984713002: Fix scanning of unterminated strings (Closed)
Patch Set: update test status Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/front_end/lib/src/fasta/scanner/string_scanner.dart ('K') | « pkg/front_end/lib/src/fasta/scanner/string_scanner.dart ('k') | pkg/front_end/test/scanner_fasta_test.dart » ('j') | pkg/front_end/testcases/regress/issue_29976.dart.outline.expect » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
index b4088b3d4fd33ab5c7efae6f9bb560ff197deb5f..16bfb059f569c25d7e5fa32851fd021090f3e6d9 100644
--- a/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart
@@ -213,7 +213,7 @@ class Utf8BytesScanner extends ArrayBasedScanner {
TokenType type, int start, bool asciiOnly, String closingQuotes) {
String source = StringToken.decodeUtf8(bytes, start, byteOffset, asciiOnly);
return new SyntheticStringToken(
- type, source + closingQuotes, start, source.length);
+ type, source + closingQuotes, tokenStart, source.length);
}
@override
« pkg/front_end/lib/src/fasta/scanner/string_scanner.dart ('K') | « pkg/front_end/lib/src/fasta/scanner/string_scanner.dart ('k') | pkg/front_end/test/scanner_fasta_test.dart » ('j') | pkg/front_end/testcases/regress/issue_29976.dart.outline.expect » ('J')

Powered by Google App Engine
This is Rietveld 408576698