VM: Remove old LinkedHashMap implementation that is no longer used

VM: Remove old LinkedHashMap implementation that is no longer used

There may be some reason that I am overlooking why we can't do this.
It works fine in the default VM config.
R=zra@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8f5a106e2f737965632d9a8dcb9abbf1930fa73f

[zra, 2017-07-20 16:44:07]

I suspect this is safe to remove, but definitely test some more configurations
locally before landing, like the precompiled runtime.

https://codereview.chromium.org/2984683002/diff/1/runtime/lib/collection_patc...
File runtime/lib/collection_patch.dart (right):

https://codereview.chromium.org/2984683002/diff/1/runtime/lib/collection_patc...
runtime/lib/collection_patch.dart:833: * This is never actually instantiated any
more - the constructor always
'the constructor always ...'

Maybe update comment to reflect the possibility to return
_InternalLinkedHashMap() when no defaults are overridden.

[erikcorry, 2017-07-28 08:28:10]

https://codereview.chromium.org/2984683002/diff/1/runtime/lib/collection_patc...
File runtime/lib/collection_patch.dart (right):

https://codereview.chromium.org/2984683002/diff/1/runtime/lib/collection_patc...
runtime/lib/collection_patch.dart:833: * This is never actually instantiated any
more - the constructor always
On 2017/07/20 16:44:07, zra wrote:
> 'the constructor always ...'
> 
> Maybe update comment to reflect the possibility to return
> _InternalLinkedHashMap() when no defaults are overridden.

Done.

[erikcorry, 2017-07-28 12:17:25]

Description was changed from

==========
VM: Remove old LinkedHashMap implementation that is no longer used

There may be some reason that I am overlooking why we can't do this.
It works fine in the default VM config.
R=zra@google.com
BUG=
==========

to

==========
VM: Remove old LinkedHashMap implementation that is no longer used

There may be some reason that I am overlooking why we can't do this.
It works fine in the default VM config.
R=zra@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8f5a106e2f737965632d9a8dcb9abbf1930fa73f
==========

[erikcorry, 2017-07-28 12:17:26]

Committed patchset #1 (id:1) manually as
8f5a106e2f737965632d9a8dcb9abbf1930fa73f (presubmit successful).

[zra, 2017-07-28 14:40:14]

lgtm

Did you test with dart_precompiled_runtime?

In the future, please wait for lgtm before submitting. Thanks!

[erikcorry, 2017-07-28 15:06:52]

On 2017/07/28 14:40:14, zra wrote:
> lgtm
> 
> Did you test with dart_precompiled_runtime?

Yes

> In the future, please wait for lgtm before submitting. Thanks!

Sorry!  Really thought I had LGTM on this.