Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2984663002: Adjust status file for some fasta front end test which are failing (see issue 30212). (Closed)

Created:
3 years, 5 months ago by siva
Modified:
3 years, 4 months ago
Reviewers:
zra, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust status file for some fasta front end test which are failing (see issue 30212). Committed: https://github.com/dart-lang/sdk/commit/23e3f55188a26e113d05f723cf12d06dd12e6e67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
siva
TBR=zra
3 years, 5 months ago (2017-07-20 02:21:32 UTC) #2
siva
Committed patchset #1 (id:1) manually as 23e3f55188a26e113d05f723cf12d06dd12e6e67 (presubmit successful).
3 years, 5 months ago (2017-07-20 02:21:46 UTC) #4
zra
lgtm
3 years, 5 months ago (2017-07-20 16:33:48 UTC) #5
ahe
Please don't skip these tests again. They test very basic features of the shared front-end, ...
3 years, 4 months ago (2017-08-01 13:01:44 UTC) #7
siva
3 years, 4 months ago (2017-08-01 14:42:14 UTC) #8
Message was sent while issue was closed.
On 2017/08/01 13:01:44, ahe wrote:
> Please don't skip these tests again. They test very basic features of the
shared
> front-end, and this would be equivalent to disabling all "cc" tests on the VM.

this has been fixed and the status file changed to reflect that.

Powered by Google App Engine
This is Rietveld 408576698