Add Class/MemberDefinition to handle synthesized classes/members

Add Class/MemberDefinition to handle synthesized classes/members

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/b5ec1dd2b84e71249d23813a67b6c0a792998bb3

[Johnni Winther, 2017-07-19 14:59:52]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-07-19 21:38:58]

it feels like this ends up adding a lot of new checks to determine what kind of
node we have throughout the codebase... is this really better than the old way
of doing it? It feels like we tried to restrict access to the data on these
objects but but now we still have to get at it, so we're adding it back in. 

lgtm

https://codereview.chromium.org/2984643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2984643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:274: ir.Node get node;
why not ir.Class here? Is this so that node can be a functionNode for closures?
If so, might want to just clarify that in the comment.

[Johnni Winther, 2017-07-21 07:44:47]

On 2017/07/19 21:38:58, Emily Fortuna wrote:
> it feels like this ends up adding a lot of new checks to determine what kind
of
> node we have throughout the codebase... is this really better than the old way
> of doing it? It feels like we tried to restrict access to the data on these
> objects but but now we still have to get at it, so we're adding it back in. 
> 
It feels like that now since we have no purely synthesized members yet.

[Johnni Winther, 2017-07-21 07:47:57]

https://codereview.chromium.org/2984643002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2984643002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:274: ir.Node get node;
On 2017/07/19 21:38:58, Emily Fortuna wrote:
> why not ir.Class here? Is this so that node can be a functionNode for
closures?
> If so, might want to just clarify that in the comment.

Done.

[Johnni Winther, 2017-07-21 08:10:02]

Description was changed from

==========
Add Class/MemberDefinition to handle synthesized classes/members
==========

to

==========
Add Class/MemberDefinition to handle synthesized classes/members

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b5ec1dd2b84e71249d23813a67b6c0a792998bb3
==========

[Johnni Winther, 2017-07-21 08:10:03]

Committed patchset #2 (id:20001) manually as
b5ec1dd2b84e71249d23813a67b6c0a792998bb3 (presubmit successful).