Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2984503002: Add missing config to libdart_jit (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
rmacnak, aam
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing config to libdart_jit It was dropped by mistake by an earlier commit and broke the Flutter build. R=aam@google.com Committed: https://github.com/dart-lang/sdk/commit/80f096fb6c4659d904c63ca3861c72c9f2f1fc49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 5 months ago (2017-07-17 22:23:46 UTC) #2
aam
On 2017/07/17 22:23:46, zra wrote: lgtm, thanks!
3 years, 5 months ago (2017-07-17 22:29:13 UTC) #3
aam
On 2017/07/17 22:23:46, zra wrote: lgtm, thanks!
3 years, 5 months ago (2017-07-17 22:29:15 UTC) #4
zra
3 years, 5 months ago (2017-07-17 22:36:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80f096fb6c4659d904c63ca3861c72c9f2f1fc49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698