chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…

Patch Set: Sync changes. Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 2ac057a7ac583dca336298142e077f3e29ef7a5f..d08c6f2405a21f066324e37cfea6a9006ad7e564 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -52,7 +52,7 @@ import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate;

import org.chromium.chrome.browser.IntentHandler.TabOpenType;

import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;

import org.chromium.chrome.browser.bookmarks.BookmarkUtils;

-import org.chromium.chrome.browser.browseractions.BrowserActionsContextMenuItemDelegate;

+import org.chromium.chrome.browser.browseractions.BrowserActionsService;

import org.chromium.chrome.browser.compositor.CompositorViewHolder;

import org.chromium.chrome.browser.compositor.layouts.Layout;

import org.chromium.chrome.browser.compositor.layouts.LayoutManager;

@@ -643,7 +643,7 @@ public class ChromeTabbedActivity

super.onStartWithNative();

setInitialOverviewState();

- BrowserActionsContextMenuItemDelegate.cancelBrowserActionsNotification();

+ BrowserActionsService.cancelBrowserActionsNotification();

resetSavedInstanceState();

}

@@ -703,8 +703,7 @@ public class ChromeTabbedActivity

toggleOverview();

}

- if (BrowserActionsContextMenuItemDelegate.toggleOverviewByBrowserActions(

- getIntent(), isOverviewVisible)) {

+ if (BrowserActionsService.shouldToggleOverview(getIntent(), isOverviewVisible)) {

toggleOverview();

}