Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2984453002: Add Browser Actions tab model selector and open a tab through it if ChromeTabbedActivity is not ava…
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 06d784e86c0c8d1c0c149c0e64ba4e9e9e9c3e08..0295ef266274ddc394110fe5abf72963a7f0e00c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -51,7 +51,7 @@ import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate;
import org.chromium.chrome.browser.IntentHandler.TabOpenType;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
-import org.chromium.chrome.browser.browseractions.BrowserActionsContextMenuItemDelegate;
+import org.chromium.chrome.browser.browseractions.BrowserActionsTabCreationService;
import org.chromium.chrome.browser.compositor.CompositorViewHolder;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.layouts.Layout;
@@ -622,7 +622,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
super.onStartWithNative();
setInitialOverviewState();
- BrowserActionsContextMenuItemDelegate.cancelBrowserActionsNotification();
+ BrowserActionsTabCreationService.cancelBrowserActionsNotification();
resetSavedInstanceState();
}
@@ -682,7 +682,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
toggleOverview();
}
- if (BrowserActionsContextMenuItemDelegate.toggleOverviewByBrowserActions(
+ if (BrowserActionsTabCreationService.toggleOverviewByBrowserActions(
Yusuf 2017/07/18 22:59:47 can we rename this to shouldToggleOverview()?
ltian 2017/08/07 23:24:11 Done.
getIntent(), isOverviewVisible)) {
toggleOverview();
}

Powered by Google App Engine
This is Rietveld 408576698