Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2984403002: dart2js_native tests: Migrate 'native STRING' to JS-calls (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js_native tests: Migrate 'native STRING' to JS-calls BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/efb3abb77b86da07ebcec3c50e8146802c1c6816

Patch Set 1 #

Patch Set 2 : more files #

Patch Set 3 : the rest of the files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+877 lines, -680 lines) Patch
M tests/compiler/dart2js_native/abstract_class_test.dart View 1 chunk +13 lines, -10 lines 0 comments Download
M tests/compiler/dart2js_native/core_type_check_native_test.dart View 1 chunk +18 lines, -14 lines 0 comments Download
M tests/compiler/dart2js_native/downcast_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/field_type2_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/field_type_test.dart View 1 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/hash_code_test.dart View 1 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 1 1 chunk +13 lines, -10 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity2_frog_test.dart View 1 1 chunk +23 lines, -20 lines 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 1 chunk +13 lines, -10 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_arguments1_frog_test.dart View 1 1 chunk +18 lines, -15 lines 0 comments Download
M tests/compiler/dart2js_native/native_checked_fields_frog_test.dart View 1 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_avoids_hidden_name_frog_test.dart View 1 1 chunk +22 lines, -16 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance1_frog_test.dart View 1 1 chunk +36 lines, -33 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance2_frog_test.dart View 1 1 chunk +35 lines, -32 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance3_frog_test.dart View 1 1 chunk +31 lines, -28 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check1_frog_test.dart View 1 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check3_frog_test.dart View 1 1 chunk +23 lines, -20 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_with_dart_methods_frog_test.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_closure_identity_frog_test.dart View 1 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_constructor_name_test.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_equals_frog_test.dart View 1 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_exception2_test.dart View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_exceptions1_frog_test.dart View 1 2 2 chunks +14 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation2_test.dart View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation3_test.dart View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation4_test.dart View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation5_test.dart View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation6_test.dart View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_invocation_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_optimization_test.dart View 1 2 1 chunk +24 lines, -21 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_1_frog_test.dart View 1 2 1 chunk +17 lines, -14 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 1 2 1 chunk +17 lines, -14 lines 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_frog_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 1 2 1 chunk +14 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 1 2 1 chunk +25 lines, -22 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 1 2 1 chunk +25 lines, -22 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_with_keyword_name_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method1_frog_test.dart View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method2_frog_test.dart View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_field_test.dart View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple2_test.dart View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple3_test.dart View 1 2 1 chunk +15 lines, -12 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_multiple_test.dart View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_test.dart View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_mixin_with_plain_test.dart View 1 2 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors2_frog_test.dart View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_named_constructors3_frog_test.dart View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception2_frog_test.dart View 1 2 1 chunk +22 lines, -19 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception4_frog_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception5_frog_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception_frog_test.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/native_novel_html_test.dart View 1 2 1 chunk +20 lines, -17 lines 0 comments Download
M tests/compiler/dart2js_native/native_null_closure_frog_test.dart View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_null_frog_test.dart View 1 2 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 1 2 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_testing.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/native_to_string_frog_test.dart View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/native_use_native_name_in_table_frog_test.dart View 1 2 1 chunk +22 lines, -19 lines 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function3_frog_test.dart View 1 2 1 chunk +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/native_wrapping_function_frog_test.dart View 1 2 1 chunk +13 lines, -10 lines 0 comments Download
M tests/compiler/dart2js_native/oddly_named_fields_test.dart View 1 2 1 chunk +8 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_native/runtimetype_test.dart View 1 2 1 chunk +21 lines, -18 lines 0 comments Download
M tests/compiler/dart2js_native/super_call_test.dart View 1 2 1 chunk +30 lines, -27 lines 0 comments Download
M tests/compiler/dart2js_native/super_property_test.dart View 1 2 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
Initial review - it seems to be working well, though most fragments require minor adjustments ...
3 years, 4 months ago (2017-07-28 21:05:16 UTC) #2
sra1
Ready for review
3 years, 4 months ago (2017-07-29 00:16:59 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-07-31 18:29:02 UTC) #4
sra1
3 years, 4 months ago (2017-07-31 19:40:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
efb3abb77b86da07ebcec3c50e8146802c1c6816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698