Migrate first block of tests in standalone to standalone_2

Migrate first block of tests in standalone to standalone_2

R=bkonyi@google.com

Committed: https://github.com/dart-lang/sdk/commit/f1689b6eb0b580e4281c47be6e3277db98fd0f31

[siva, 2017-07-28 15:49:11]

asiva@google.com changed reviewers:
+ bkonyi@google.com

[bkonyi, 2017-07-28 19:51:31]

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/deoptimi...
File tests/standalone_2/deoptimization_test.dart (left):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/deoptimi...
tests/standalone_2/deoptimization_test.dart:86: final nan = 0.0 / 0.0;
Was this used anywhere?

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/float_ar...
File tests/standalone_2/float_array_test.dart (left):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/float_ar...
tests/standalone_2/float_array_test.dart:220: testBadValues32();
These tests should probably be split into float_array_static_test.dart and made
into tests checking for static errors.

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/standalo...
File tests/standalone_2/standalone_2.status (right):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/standalo...
tests/standalone_2/standalone_2.status:1: # Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
Since this is a new file, shouldn't the copyright year be updated?

[siva, 2017-07-28 21:51:10]

Addressed review comments.

PTAL.

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/deoptimi...
File tests/standalone_2/deoptimization_test.dart (left):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/deoptimi...
tests/standalone_2/deoptimization_test.dart:86: final nan = 0.0 / 0.0;
On 2017/07/28 19:51:31, bkonyi wrote:
> Was this used anywhere?

No it was not used and the analyzer complained about that.

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/float_ar...
File tests/standalone_2/float_array_test.dart (left):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/float_ar...
tests/standalone_2/float_array_test.dart:220: testBadValues32();
On 2017/07/28 19:51:31, bkonyi wrote:
> These tests should probably be split into float_array_static_test.dart and
made
> into tests checking for static errors.

Done.

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/standalo...
File tests/standalone_2/standalone_2.status (right):

https://codereview.chromium.org/2984363004/diff/1/tests/standalone_2/standalo...
tests/standalone_2/standalone_2.status:1: # Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
On 2017/07/28 19:51:31, bkonyi wrote:
> Since this is a new file, shouldn't the copyright year be updated?

Done.

[bkonyi, 2017-07-28 22:05:02]

LGTM after removing Expect code in float_array_static_test.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
File tests/standalone_2/float_array_static_test.dart (right):

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:20:
/*@compile-error=unspecified*/ Expect.equals(0, list.indexOf(10));
I don't think you need Expect.equals(...), since just doing list.indexOf(10)
will cause an error.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:29: Expect.throws(() {
You can remove the Expect.throws(...) since these won't actually throw anymore.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:42:
/*@compile-error=unspecified*/ Expect.equals(0, list.indexOf(10));
See above.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:51: Expect.throws(() {
See above.

[siva, 2017-07-28 22:34:27]

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
File tests/standalone_2/float_array_static_test.dart (right):

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:20:
/*@compile-error=unspecified*/ Expect.equals(0, list.indexOf(10));
On 2017/07/28 22:05:02, bkonyi wrote:
> I don't think you need Expect.equals(...), since just doing list.indexOf(10)
> will cause an error.

True but using just list.indexOf(10) would cause analyzer errors (unused
expression), I would have to assign it to something, this way we actually use
the return value from list.indexOf(10).

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:29: Expect.throws(() {
On 2017/07/28 22:05:02, bkonyi wrote:
> You can remove the Expect.throws(...) since these won't actually throw
anymore.

Done.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:42:
/*@compile-error=unspecified*/ Expect.equals(0, list.indexOf(10));
On 2017/07/28 22:05:02, bkonyi wrote:
> See above.

See reply above.

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:51: Expect.throws(() {
On 2017/07/28 22:05:02, bkonyi wrote:
> See above.

Done.

[bkonyi, 2017-07-28 22:36:09]

LGTM

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
File tests/standalone_2/float_array_static_test.dart (right):

https://codereview.chromium.org/2984363004/diff/20001/tests/standalone_2/floa...
tests/standalone_2/float_array_static_test.dart:20:
/*@compile-error=unspecified*/ Expect.equals(0, list.indexOf(10));
On 2017/07/28 at 22:34:27, siva wrote:
> On 2017/07/28 22:05:02, bkonyi wrote:
> > I don't think you need Expect.equals(...), since just doing list.indexOf(10)
> > will cause an error.
> 
> True but using just list.indexOf(10) would cause analyzer errors (unused
expression), I would have to assign it to something, this way we actually use
the return value from list.indexOf(10).

Fair enough. Don't worry about it then.

[siva, 2017-08-01 16:05:07]

Description was changed from

==========
Migrate first block of tests in standalone to standalone_2
==========

to

==========
Migrate first block of tests in standalone to standalone_2

R=bkonyi@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f1689b6eb0b580e4281c47be6e3277db98fd0f31
==========

[siva, 2017-08-01 16:05:08]

Committed patchset #3 (id:40001) manually as
f1689b6eb0b580e4281c47be6e3277db98fd0f31 (presubmit successful).