Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 298433003: Roll webrtc/libjingle to 6189. (Closed)

Created:
6 years, 7 months ago by Ronghua Wu (Left Chromium)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ami GONE FROM CHROMIUM, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : wei #

Patch Set 4 : rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Ronghua Wu (Left Chromium)
6 years, 7 months ago (2014-05-19 17:43:53 UTC) #1
Ami GONE FROM CHROMIUM
Please use the old:new conventions in roll CL descriptions. https://codereview.chromium.org/298433003/diff/20001/DEPS File DEPS (left): https://codereview.chromium.org/298433003/diff/20001/DEPS#oldcode57 DEPS:57: ...
6 years, 7 months ago (2014-05-19 17:51:27 UTC) #2
Ronghua Wu (Left Chromium)
Updated cl description. https://codereview.chromium.org/298433003/diff/20001/DEPS File DEPS (left): https://codereview.chromium.org/298433003/diff/20001/DEPS#oldcode57 DEPS:57: "webrtc_revision": "6174", On 2014/05/19 17:51:27, Ami ...
6 years, 7 months ago (2014-05-19 17:54:20 UTC) #3
wjia(left Chromium)
lgtm % one minor comment. https://codereview.chromium.org/298433003/diff/20001/content/renderer/media/webrtc_audio_device_impl.cc File content/renderer/media/webrtc_audio_device_impl.cc (right): https://codereview.chromium.org/298433003/diff/20001/content/renderer/media/webrtc_audio_device_impl.cc#newcode173 content/renderer/media/webrtc_audio_device_impl.cc:173: int64_t ntp_ts = 0; ...
6 years, 7 months ago (2014-05-19 17:56:26 UTC) #4
Ronghua Wu (Left Chromium)
https://codereview.chromium.org/298433003/diff/20001/content/renderer/media/webrtc_audio_device_impl.cc File content/renderer/media/webrtc_audio_device_impl.cc (right): https://codereview.chromium.org/298433003/diff/20001/content/renderer/media/webrtc_audio_device_impl.cc#newcode173 content/renderer/media/webrtc_audio_device_impl.cc:173: int64_t ntp_ts = 0; On 2014/05/19 17:56:26, wjia wrote: ...
6 years, 7 months ago (2014-05-19 17:58:11 UTC) #5
Ronghua Wu (Left Chromium)
The CQ bit was checked by ronghuawu@chromium.org
6 years, 7 months ago (2014-05-19 17:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/298433003/40001
6 years, 7 months ago (2014-05-19 18:01:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 20:57:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 20:58:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28555)
6 years, 7 months ago (2014-05-19 20:58:29 UTC) #10
Ronghua Wu (Left Chromium)
Roll webrtc/libjingle to 6187:6189. BUG=
6 years, 7 months ago (2014-05-19 21:30:17 UTC) #11
Ronghua Wu (Left Chromium)
6 years, 7 months ago (2014-05-19 21:36:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 manually as r271491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698