runtime/vm/timeline_macos.cc - Issue 2984313002: Allocate the fixed-size timeline buffer with virtual memory instead of malloc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/timeline_macos.cc

Issue 2984313002: Allocate the fixed-size timeline buffer with virtual memory instead of malloc. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/timeline_macos.cc

diff --git a/runtime/vm/timeline_macos.cc b/runtime/vm/timeline_macos.cc

index 18c13118d1d603e281d844386108c450deae5eaf..a17b590a4ed01c3d3e5454e415b6b43d860a1130 100644

--- a/runtime/vm/timeline_macos.cc

+++ b/runtime/vm/timeline_macos.cc

@@ -33,7 +33,7 @@ TimelineEventBlock* TimelineEventPlatformRecorder::GetNewBlockLocked() {

if (block_cursor_ == num_blocks_) {

block_cursor_ = 0;

}

- TimelineEventBlock* block = blocks_[block_cursor_++];

+ TimelineEventBlock* block = &blocks_[block_cursor_++];

block->Reset();

block->Open();

return block;