Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: runtime/vm/timeline.h

Issue 2984313002: Allocate the fixed-size timeline buffer with virtual memory instead of malloc. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 380df4a752569a9f97c164ea6a092f171ce3db19..eecb0dd2f01f06cda623309c41bd44eb42878047 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -27,6 +27,7 @@ class TimelineEvent;
class TimelineEventBlock;
class TimelineEventRecorder;
class TimelineStream;
+class VirtualMemory;
zra 2017/07/27 19:05:44 Why can't/shouldn't this #include "vm/virtual_memo
rmacnak 2017/07/27 20:24:33 It doesn't need it. timeline.h gets included in a
class Zone;
// (name, enabled by default for isolate).
@@ -705,7 +706,8 @@ class TimelineEventFixedBufferRecorder : public TimelineEventRecorder {
void PrintJSONEvents(JSONArray* array, TimelineEventFilter* filter);
- TimelineEventBlock** blocks_;
+ VirtualMemory* memory_;
+ TimelineEventBlock* blocks_;
intptr_t capacity_;
intptr_t num_blocks_;
intptr_t block_cursor_;
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698