Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2984313002: Allocate the fixed-size timeline buffer with virtual memory instead of malloc. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allocate the fixed-size timeline buffer with virtual memory instead of malloc. Allows naming the memory region; removes some pressure from jemalloc. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/00290c3813751cc7ee78a1dc631d962d903d0859

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M runtime/vm/timeline.h View 2 chunks +3 lines, -1 line 2 comments Download
M runtime/vm/timeline.cc View 6 chunks +21 lines, -19 lines 0 comments Download
M runtime/vm/timeline_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
3 years, 4 months ago (2017-07-27 18:51:50 UTC) #3
zra
lgtm https://codereview.chromium.org/2984313002/diff/1/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/2984313002/diff/1/runtime/vm/timeline.h#newcode30 runtime/vm/timeline.h:30: class VirtualMemory; Why can't/shouldn't this #include "vm/virtual_memory.h" ?
3 years, 4 months ago (2017-07-27 19:05:45 UTC) #4
rmacnak
https://codereview.chromium.org/2984313002/diff/1/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/2984313002/diff/1/runtime/vm/timeline.h#newcode30 runtime/vm/timeline.h:30: class VirtualMemory; On 2017/07/27 19:05:44, zra wrote: > Why ...
3 years, 4 months ago (2017-07-27 20:24:33 UTC) #5
rmacnak
3 years, 4 months ago (2017-07-27 20:37:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00290c3813751cc7ee78a1dc631d962d903d0859 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698