Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: syzygy/pe/unittest_util.h

Issue 2984303002: Split the testing class into two. (Closed)
Patch Set: Removed parametrization with Clang until the necessary fixes are done. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/pe/unittest_util.h
diff --git a/syzygy/pe/unittest_util.h b/syzygy/pe/unittest_util.h
index 15c1dc1e2e8660f8999147701c7ec5fe6edbc6ad..f9464995c10d6eb1740d5dc7fc2c4daebcdecfb0 100644
--- a/syzygy/pe/unittest_util.h
+++ b/syzygy/pe/unittest_util.h
@@ -42,6 +42,9 @@ extern const wchar_t kTestDllPdbName64[];
extern const wchar_t kIntegrationTestsDllName[];
extern const wchar_t kIntegrationTestsDllPdbName[];
+// Name of the clang instrumented integrations tests DLL
Sébastien Marchand 2017/08/01 19:27:36 You don't need this yet.
njanevsk 2017/08/03 01:23:21 Is there a problem if it's left here? Cause it is
Sébastien Marchand 2017/08/03 18:12:59 You don't need this in this CL at all, here or in
+extern const wchar_t kIntegrationTestsClangDllName[];
+
// Name of the DLL containing an empty exports directory.
extern const wchar_t kNoExportsDllName[];
extern const wchar_t kNoExportsDllPdbName[];

Powered by Google App Engine
This is Rietveld 408576698