Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2984273002: Added status for syntax_test/none. (Closed)

Created:
3 years, 4 months ago by eernst
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added status for syntax_test/none. Other tools had this status entry, but dartk/dartkp were omitted. In all cases, the change is needed because the allowed usages of `void` have been relaxed, but most tools do not support that yet. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/bb8d6ed680e27aa43e7c1111c9d49f1a2cf730a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/language/language_kernel.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
Adding status change incorrectly omitted in CL 2992623002.
3 years, 4 months ago (2017-07-27 11:55:13 UTC) #2
floitsch
LGTM.
3 years, 4 months ago (2017-07-27 12:02:31 UTC) #3
eernst
3 years, 4 months ago (2017-07-27 12:03:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb8d6ed680e27aa43e7c1111c9d49f1a2cf730a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698