Issue 2984253002: Fix analyzer error in dart2js modelx. We will need to watch for perf regressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2984253002: Fix analyzer error in dart2js modelx. We will need to watch for perf regressions. (Closed)

Created:
3 years, 4 months ago by Emily Fortuna

Modified:
3 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix analyzer error in dart2js modelx. We will need to watch for perf regressions. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4bcde03ed905b9439dfa020de17e9add6cfc2098

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	pkg/compiler/lib/src/elements/modelx.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 6 (3 generated)

Emily Fortuna

3 years, 4 months ago (2017-07-26 19:52:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4bcde03ed905b9439dfa020de17e9add6cfc2098 (presubmit successful).