Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: sdk/BUILD.gn

Issue 2984243002: Include platform.dill files in sdk builds (Closed)
Patch Set: cl comments, rename outputs Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | utils/generate_patch_sdk.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/BUILD.gn
diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index 116f72104a2791b6341687d1014a9df9ff85cf87..98f47ebcc28b6e97c07765ad330407db3c2746c4 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -65,6 +65,8 @@ if (is_fuchsia ||
# ......_internal/
#.........spec.sum
#.........strong.sum
+#.........dart2js_platform.dill
+#.........vm_outline.dill
#.........dev_compiler/
# ......analysis_server/
# ......analyzer/
@@ -444,6 +446,36 @@ copy("copy_analysis_summaries") {
]
}
+# This rule copies vm's outline.dill file to lib/_internal
+copy("copy_vm_dill_files") {
+ visibility = [ ":create_common_sdk" ]
+ deps = [
+ ":copy_libraries",
+ "../runtime/vm:patched_sdk",
+ ]
+ sources = [
+ "$root_out_dir/patched_sdk/outline.dill",
+ ]
+ outputs = [
+ "$root_out_dir/dart-sdk/lib/_internal/vm_outline.dill",
+ ]
+}
+
+# This rule copies dart2js's platform.dill file to lib/_internal
+copy("copy_dart2js_dill_files") {
+ visibility = [ ":create_full_sdk" ]
+ deps = [
+ ":copy_libraries",
+ "../utils/compiler:patched_dart2js_sdk",
+ ]
+ sources = [
+ "$root_out_dir/patched_dart2js_sdk/platform.dill",
+ ]
+ outputs = [
+ "$root_out_dir/dart-sdk/lib/_internal/dart2js_platform.dill",
+ ]
+}
+
# This rule copies ddc summaries to lib/_internal
copy("copy_dev_compiler_summary") {
visibility = [ ":copy_dev_compiler_sdk" ]
@@ -704,6 +736,7 @@ group("create_common_sdk") {
":copy_api_readme",
":copy_dart",
":copy_dartdoc_files",
+ ":copy_vm_dill_files",
zra 2017/07/26 21:23:44 nit: Please keep this list alphabetized.
Siggi Cherem (dart-lang) 2017/07/26 21:46:21 Done.
":copy_headers",
":copy_libraries_dart",
":copy_license",
@@ -739,6 +772,7 @@ group("create_full_sdk") {
deps = [
":copy_dev_compiler_sdk",
+ ":copy_dart2js_dill_files",
zra 2017/07/26 21:23:44 ditto
Siggi Cherem (dart-lang) 2017/07/26 21:46:21 Done.
":copy_full_sdk_libraries",
":copy_full_sdk_scripts",
":copy_full_sdk_snapshots",
« no previous file with comments | « BUILD.gn ('k') | utils/generate_patch_sdk.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698