Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tools/testing/dart/status_file.dart

Issue 2984203002: Move the status file parser into its own package. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_expression.dart ('k') | tools/testing/dart/summary_report.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_file.dart
diff --git a/tools/testing/dart/status_file.dart b/tools/testing/dart/status_file.dart
deleted file mode 100644
index df64025ba03e3a67f922954f6c305aef7e3a2c99..0000000000000000000000000000000000000000
--- a/tools/testing/dart/status_file.dart
+++ /dev/null
@@ -1,198 +0,0 @@
-// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io';
-
-import 'environment.dart';
-import 'expectation.dart';
-import 'path.dart';
-import 'status_expression.dart';
-
-/// Matches the header that begins a new section, like:
-///
-/// [ $compiler == dart2js && $minified ]
-final _sectionPattern = new RegExp(r"^\[(.+?)\]");
-
-/// Matches an entry that defines the status for a path in the current section,
-/// like:
-///
-/// some/path/to/some_test: Pass || Fail
-final _entryPattern = new RegExp(r"^([^:#]+):(.*)");
-
-/// Matches an issue number in a comment, like:
-///
-/// blah_test: Fail # Issue 1234
-/// ^^^^
-final _issuePattern = new RegExp(r"[Ii]ssue (\d+)");
-
-/// A parsed status file, which describes how a collection of tests are
-/// expected to behave under various configurations and conditions.
-///
-/// Each status file is made of a series of sections. Each section begins with
-/// a header, followed by a series of entries. A header is enclosed in square
-/// brackets and contains a Boolean expression. That expression is evaluated in
-/// an environment. If it evaluates to true, then the entries after the header
-/// take effect.
-///
-/// Each entry is a glob-like file path followed by a colon and then a
-/// comma-separated list of [Expectation]s. The path may point to an individual
-/// file, or a directory, in which case it applies to all files under that path.
-///
-/// Entries may also appear before any section header, in which case they
-/// always apply.
-class StatusFile {
- final String _path;
- final List<StatusSection> sections = [];
-
- /// Parses the status file at [_path].
- StatusFile.read(this._path) {
- var lines = new File(_path).readAsLinesSync();
-
- // The current section whose rules are being parsed.
- StatusSection section;
-
- var lineNumber = 0;
-
- for (var line in lines) {
- lineNumber++;
-
- fail(String message, [List<String> errors]) {
- print('$message in "$_shortPath" line $lineNumber:\n$line');
-
- if (errors != null) {
- for (var error in errors) {
- print("- ${error.replaceAll('\n', '\n ')}");
- }
- }
- exit(1);
- }
-
- // Strip off the comment and whitespace.
- var source = line;
- var comment = "";
- var hashIndex = line.indexOf('#');
- if (hashIndex >= 0) {
- source = line.substring(0, hashIndex);
- comment = line.substring(hashIndex);
- }
- source = source.trim();
-
- // Ignore empty (or comment-only) lines.
- if (source.isEmpty) continue;
-
- // See if we are starting a new section.
- var match = _sectionPattern.firstMatch(source);
- if (match != null) {
- try {
- var condition = Expression.parse(match[1].trim());
-
- var errors = <String>[];
- condition.validate(errors);
-
- if (errors.isNotEmpty) {
- var s = errors.length > 1 ? "s" : "";
- fail('Validation error$s', errors);
- }
-
- section = new StatusSection(condition);
- sections.add(section);
- } on FormatException {
- fail("Status expression syntax error");
- }
- continue;
- }
-
- // Otherwise, it should be a new entry under the current section.
- match = _entryPattern.firstMatch(source);
- if (match != null) {
- var path = match[1].trim();
- // TODO(whesse): Handle test names ending in a wildcard (*).
- var expectations = <Expectation>[];
- for (var name in match[2].split(",")) {
- name = name.trim();
- try {
- expectations.add(Expectation.find(name));
- } on ArgumentError {
- fail('Unrecognized test expectation "$name"');
- }
- }
-
- var issue = _issueNumber(comment);
-
- // If we haven't found a section header yet, create an implicit section
- // that matches everything.
- if (section == null) {
- section = new StatusSection(null);
- sections.add(section);
- }
-
- section.entries.add(new StatusEntry(path, expectations, issue));
- continue;
- }
-
- fail("Unrecognized input");
- }
- }
-
- /// Gets the path to this status file relative to the Dart repo root.
- String get _shortPath {
- var repoRoot = new Path(Platform.script
- .toFilePath(windows: Platform.operatingSystem == "windows"))
- .join(new Path("../../../../"));
- return new Path(_path).relativeTo(repoRoot).toString();
- }
-
- /// Returns the issue number embedded in [comment] or `null` if there is none.
- int _issueNumber(String comment) {
- var match = _issuePattern.firstMatch(comment);
- if (match == null) return null;
-
- return int.parse(match[1]);
- }
-
- String toString() {
- var buffer = new StringBuffer();
- for (var section in sections) {
- buffer.writeln("[${section._condition}]");
-
- for (var entry in section.entries) {
- buffer.write("${entry.path}: ${entry.expectations.join(', ')}");
- if (entry.issue != null) buffer.write(" # Issue ${entry.issue}");
- buffer.writeln();
- }
-
- buffer.writeln();
- }
-
- return buffer.toString();
- }
-}
-
-/// One section in a status file.
-///
-/// Contains the condition from the header that begins the section, then all of
-/// the entries within the section.
-class StatusSection {
- /// The expression that determines when this section is applied.
- ///
- /// May be `null` for paths that appear before any section header in the file.
- /// In that case, the section always applies.
- final Expression _condition;
- final List<StatusEntry> entries = [];
-
- /// Returns true if this section should apply in the given [environment].
- bool isEnabled(Environment environment) =>
- _condition == null || _condition.evaluate(environment);
-
- StatusSection(this._condition);
-}
-
-/// Describes the test status of the file or files at a given path.
-class StatusEntry {
- final String path;
- final List<Expectation> expectations;
- final int issue;
-
- StatusEntry(this.path, this.expectations, this.issue);
-}
« no previous file with comments | « tools/testing/dart/status_expression.dart ('k') | tools/testing/dart/summary_report.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698