Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart

Issue 2984153002: Start marking @_fastaProblem, fix for unresolved mixin, fix for type parameter context. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_common.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
index 637d79607cfe73b9ff344949d19f95a58273a0bd..92eade940472411cdbf0410e14a1c2f5ce88a4f9 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
@@ -40,6 +40,9 @@ main() {
});
}
+/// Tests marked with this annotation fail because of a Fasta problem.
+const _fastaProblem = const Object();
+
@reflectiveTest
class ResynthesizeKernelStrongTest extends ResynthesizeTest {
final resourceProvider = new MemoryResourceProvider(context: pathos.posix);
@@ -114,18 +117,7 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_class_alias_with_forwarding_constructors_type_substitution() async {
- await super
- .test_class_alias_with_forwarding_constructors_type_substitution();
- }
-
- @failingTest
- test_class_alias_with_forwarding_constructors_type_substitution_complex() async {
- await super
- .test_class_alias_with_forwarding_constructors_type_substitution_complex();
- }
-
- @failingTest
+ @_fastaProblem
test_class_constructor_field_formal_multiple_matching_fields() async {
// Fasta does not generate the class.
// main() with a fatal error is generated instead.
@@ -143,31 +135,34 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
+ @_fastaProblem
test_class_interfaces_unresolved() async {
+ // Fasta generates additional `#errors` top-level variable.
await super.test_class_interfaces_unresolved();
}
@failingTest
+ @_fastaProblem
test_class_mixins_unresolved() async {
+ // Fasta generates additional `#errors` top-level variable.
await super.test_class_mixins_unresolved();
}
@failingTest
+ @_fastaProblem
test_class_supertype_unresolved() async {
+ // Fasta generates additional `#errors` top-level variable.
await super.test_class_supertype_unresolved();
}
@failingTest
+ @_fastaProblem
test_class_type_parameters_bound() async {
+ // Fasta does not provide a flag for explicit vs. implicit Object bound.
await super.test_class_type_parameters_bound();
}
@failingTest
- test_class_type_parameters_f_bound_complex() async {
- await super.test_class_type_parameters_f_bound_complex();
- }
-
- @failingTest
test_closure_generic() async {
await super.test_closure_generic();
}
@@ -962,11 +957,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_inferred_type_refers_to_bound_type_param() async {
- await super.test_inferred_type_refers_to_bound_type_param();
- }
-
- @failingTest
test_inferred_type_refers_to_function_typed_param_of_typedef() async {
await super.test_inferred_type_refers_to_function_typed_param_of_typedef();
}
@@ -2118,7 +2108,7 @@ class _KernelLibraryResynthesizerContextImpl
InterfaceType getInterfaceType(
ElementImpl context, kernel.Supertype kernelType) {
return _getInterfaceType(
- kernelType.className.canonicalName, kernelType.typeArguments);
+ context, kernelType.className.canonicalName, kernelType.typeArguments);
}
@override
@@ -2130,8 +2120,8 @@ class _KernelLibraryResynthesizerContextImpl
if (kernelType is kernel.DynamicType) return DynamicTypeImpl.instance;
if (kernelType is kernel.VoidType) return VoidTypeImpl.instance;
if (kernelType is kernel.InterfaceType) {
- return _getInterfaceType(
- kernelType.className.canonicalName, kernelType.typeArguments);
+ return _getInterfaceType(context, kernelType.className.canonicalName,
+ kernelType.typeArguments);
}
if (kernelType is kernel.TypeParameterType) {
kernel.TypeParameter kTypeParameter = kernelType.parameter;
@@ -2214,7 +2204,7 @@ class _KernelLibraryResynthesizerContextImpl
throw new UnimplementedError('Should not be reached.');
}
- InterfaceType _getInterfaceType(
+ InterfaceType _getInterfaceType(ElementImpl context,
kernel.CanonicalName className, List<kernel.DartType> kernelArguments) {
var libraryName = className.parent;
var libraryElement = _resynthesizer.getLibrary(libraryName.name);
@@ -2227,7 +2217,7 @@ class _KernelLibraryResynthesizerContextImpl
return new InterfaceTypeImpl.elementWithNameAndArgs(
classElement, classElement.name, () {
List<DartType> arguments = kernelArguments
- .map((kernel.DartType k) => getType(classElement, k))
+ .map((kernel.DartType k) => getType(context, k))
.toList(growable: false);
return arguments;
});
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_common.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698