Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2984153002: Start marking @_fastaProblem, fix for unresolved mixin, fix for type parameter context. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start marking @_fastaProblem, fix for unresolved mixin, fix for type parameter context. R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e3c418a3dba6ccbaa3cb5ed9768348c16ddeb0e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 8 chunks +17 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-24 16:11:42 UTC) #1
Brian Wilkerson
lgtm, although if we think we might want to use this annotation in any other ...
3 years, 5 months ago (2017-07-24 16:59:26 UTC) #2
scheglov
On 2017/07/24 16:59:26, Brian Wilkerson wrote: > lgtm, although if we think we might want ...
3 years, 5 months ago (2017-07-24 17:05:41 UTC) #3
scheglov
3 years, 5 months ago (2017-07-24 18:50:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3c418a3dba6ccbaa3cb5ed9768348c16ddeb0e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698