Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 298413004: Remove the importedDocument functions from HTML imports classes. (Closed)

Created:
6 years, 6 months ago by dglazkov
Modified:
6 years, 6 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Remove the importedDocument functions from HTML imports classes. The notion of "importedDocument" only exists at the LinkImport level (because its used, HTMLLinkElement has to deal with both importer and the importee), so we can just call the imported documents simply "documents" inside of the imports plumbing. No functional changes, plumbotron. R=morrita BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M Source/core/html/imports/HTMLImportChild.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 4 chunks +8 lines, -15 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dglazkov
6 years, 6 months ago (2014-05-28 19:56:44 UTC) #1
Hajime Morrita
lgtm.
6 years, 6 months ago (2014-05-28 20:40:31 UTC) #2
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 6 months ago (2014-06-01 16:44:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/298413004/1
6 years, 6 months ago (2014-06-01 16:45:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-01 17:57:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 17:57:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12696)
6 years, 6 months ago (2014-06-01 17:57:38 UTC) #7
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 6 months ago (2014-06-01 18:48:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/298413004/1
6 years, 6 months ago (2014-06-01 18:48:27 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 18:48:55 UTC) #10
Message was sent while issue was closed.
Change committed as 175224

Powered by Google App Engine
This is Rietveld 408576698