Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 298413003: Add ErrorUtils::FormatErrorMessage() syntax to ExtensionFunction::Error(). (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add ErrorUtils::FormatErrorMessage() syntax to ExtensionFunction::Error(). R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273430

Patch Set 1 #

Patch Set 2 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M extensions/browser/extension_function.h View 2 chunks +13 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
6 years, 6 months ago (2014-05-28 19:45:10 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 6 months ago (2014-05-28 20:46:48 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-05-28 21:41:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/298413003/10001
6 years, 6 months ago (2014-05-28 21:43:39 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 01:18:11 UTC) #5
Message was sent while issue was closed.
Change committed as 273430

Powered by Google App Engine
This is Rietveld 408576698