Migrate test block 5 to Dart 2.0.

Migrate test block 5 to Dart 2.0.

Unusual things in this block:
- date_time10_test.dart had no strong mode fork, and reveals what looks
like a legit DDC bug at first glance.  Excluded it for now in the status file.
- date_time_test.dart had small differences between the two forks that looked
like an error.  Fixed.

BUG=
R=bkonyi@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/998dd24dccbe630bfeb9eeadf4fc5ff901a62567

[jcollins, 2017-07-21 17:48:51]

jcollins@google.com changed reviewers:
+ bkonyi@google.com, rnystrom@google.com

[bkonyi, 2017-07-21 20:22:39]

LGTM for the most part. Could you point out where the small error was in the
date_time_test so we can take a look? It's basically impossible to see with the
diff.

[jcollins, 2017-07-21 20:26:25]

On 2017/07/21 20:22:39, bkonyi wrote:
> LGTM for the most part. Could you point out where the small error was in the
> date_time_test so we can take a look? It's basically impossible to see with
the
> diff.

Oh, right, yes, that is hard to find.

Compare:

https://github.com/dart-lang/sdk/blob/master/tests/corelib_strong/date_time_t...

and 

https://github.com/dart-lang/sdk/blob/master/tests/corelib/date_time_test.dar...

(similar error a few lines down from referenced line as well)

I went with the latter's version.

[bkonyi, 2017-07-21 20:39:54]

On 2017/07/21 20:26:25, jcollins wrote:
> On 2017/07/21 20:22:39, bkonyi wrote:
> > LGTM for the most part. Could you point out where the small error was in the
> > date_time_test so we can take a look? It's basically impossible to see with
> the
> > diff.
> 
> Oh, right, yes, that is hard to find.
> 
> Compare:
> 
>
https://github.com/dart-lang/sdk/blob/master/tests/corelib_strong/date_time_t...
> 
> and 
> 
>
https://github.com/dart-lang/sdk/blob/master/tests/corelib/date_time_test.dar...
> 
> (similar error a few lines down from referenced line as well)
> 
> I went with the latter's version.

Thanks! LGTM :)

[jcollins, 2017-07-21 21:00:57]

Patchset #2 (id:20001) has been deleted

[Bob Nystrom, 2017-07-21 22:05:18]

lgtm

[jcollins, 2017-07-24 21:19:03]

Description was changed from

==========
Migrate test block 5 to Dart 2.0.

Unusual things in this block:
- date_time10_test.dart had no strong mode fork, and reveals what looks
like a legit DDC bug at first glance.  Excluded it for now in the status file.
- date_time_test.dart had small differences between the two forks that looked
like an error.  Fixed.

BUG=
==========

to

==========
Migrate test block 5 to Dart 2.0.

Unusual things in this block:
- date_time10_test.dart had no strong mode fork, and reveals what looks
like a legit DDC bug at first glance.  Excluded it for now in the status file.
- date_time_test.dart had small differences between the two forks that looked
like an error.  Fixed.

BUG=
R=bkonyi@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/998dd24dccbe630bfeb9eeadf4fc5ff901a62567
==========

[jcollins, 2017-07-24 21:19:05]

Committed patchset #3 (id:60001) manually as
998dd24dccbe630bfeb9eeadf4fc5ff901a62567 (presubmit successful).