Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2983993002: Check in the .packages file for the migration tool. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check in the .packages file for the migration tool. This way, users don't have to run "pub get" on it before they can use it. Since the .packages file only contains relative paths, it's safe to check into the repo. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/456ebea38f8bc3bea2a62b46c41647b04d348f14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
D tools/migration/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A tools/migration/.packages View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 5 months ago (2017-07-20 20:39:35 UTC) #2
bkonyi
LGTM
3 years, 5 months ago (2017-07-20 20:51:04 UTC) #3
Bob Nystrom
3 years, 5 months ago (2017-07-20 21:01:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
456ebea38f8bc3bea2a62b46c41647b04d348f14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698