Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2983973002: Revert "Improve hashCode for closure objects" (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Improve hashCode for closure objects" This reverts commit b1197eb7141762fe42d7c738fa3395f3dc8c2b9d. Revert "Correct assertions for validating layout of Closure objects" This reverts commit b1215faa59a7e9bb7eed3b142ad7f3fa7581349c. Revert "Add identityHashCode to the list of VM entry points in precompiler" This reverts commit e1d04cc24251add1d88c5e39a223e597dab58a24. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/51d580d8bfbf870c7d475d0add4475390cb41dac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -93 lines) Patch
M runtime/lib/function.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/lib/function.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/bootstrap.cc View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_entry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M runtime/vm/object.h View 5 chunks +4 lines, -9 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +18 lines, -36 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-20 15:27:04 UTC) #2
siva
lgtm. You also made a status file change after this CL, I guess you skipped ...
3 years, 5 months ago (2017-07-20 15:33:24 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-20 15:34:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51d580d8bfbf870c7d475d0add4475390cb41dac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698