Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2983933002: Revert "Add nonboxed closure class fields." (Closed)

Created:
3 years, 5 months ago by sivachandra
Modified:
3 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add nonboxed closure class fields." This is to get the vm-kernel bots go green. Test failing on the bot: pkg/front_end/test/fasta/analyze_test This reverts commit dc99692b41522073fba4fb5ee1a3654361d0567e. TBR=efortuna Committed: https://github.com/dart-lang/sdk/commit/bff25c89fe8de6874c8f289bb255d5b10db23fef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -180 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 14 chunks +50 lines, -165 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 3 chunks +1 line, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sivachandra
3 years, 5 months ago (2017-07-20 00:21:45 UTC) #3
sivachandra
Committed patchset #1 (id:1) manually as bff25c89fe8de6874c8f289bb255d5b10db23fef (presubmit successful).
3 years, 5 months ago (2017-07-20 00:23:42 UTC) #6
Emily Fortuna
3 years, 5 months ago (2017-07-20 00:31:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698