Issue 298393005: Tinker with SkLazyFnPtr a bit.

Issue 298393005: Tinker with SkLazyFnPtr a bit. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Tinker with SkLazyFnPtr a bit. I moved the choice function from a get() arg to a template parameter. I think this removes some of the overemphasis on "choose" from the call site, making it a bit more clear it's normally very cheap. It's also now more in line with what I'm thinking now for the general SkLazyPtr<T>, which needs a "create" parameter just like SkLazyFnPtr's "choose", but also a "destroy" that it might use both in .get() but also at process exit. That "destroy" needs to be made part of the type to be called at exit, so might as well make "create" and "choose" template parameters too so it's all consistent. Also, add (C). BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14971

Patch Set 1 #

Patch Set 2 : operator F #

Patch Set 3 : Zero-initialization, and put get() back. #

Patch Set 4 : .get() #

Patch Set 5 : drop returns #

Patch Set 6 : namespace #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -23 lines)			Patch
	M	src/core/SkLazyFnPtr.h	View	1 2 3	6 chunks	+17 lines, -8 lines	0 comments	Download
	M	src/core/SkUtils.cpp	View	1 2 3 4 5	1 chunk	+21 lines, -15 lines	0 comments	Download