Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2983913002: Add utility method to SubscriptionManager (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M pkg/analyzer_plugin/lib/utilities/subscriptions/subscription_manager.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/subscriptions/subscription_manager_test.dart View 1 chunk +25 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-19 21:40:21 UTC) #2
mfairhurst
lgtm
3 years, 5 months ago (2017-07-20 21:17:22 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-21 14:25:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a275e6df89b29306a7fc1b0a4ddf8da3dd552c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698