Issue 2983883002: Reset overscroll state when OverscrollWindowDelegate is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
3 years, 5 months ago by mfomitchev

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, jam, darin-cc_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Reset overscroll state when OverscrollWindowDelegate is destroyed. BUG=727718

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	content/browser/web_contents/aura/overscroll_navigation_overlay.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/aura/overscroll_window_animation.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/browser/web_contents/aura/overscroll_window_delegate.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/aura/overscroll_window_delegate.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (5 generated)

mfomitchev

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

3 years, 5 months ago (2017-07-19 19:28:37 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2983883002/1

3 years, 5 months ago (2017-07-19 19:28:52 UTC) #2

mfomitchev

Description was changed from ========== Rest overscroll state when OVerscrollWindowDelegate is destroyed. BUG=727718 ========== to ...

3 years, 5 months ago (2017-07-19 20:50:01 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 5 months ago (2017-07-19 21:04:41 UTC) #4

commit-bot: I haz the power

3 years, 5 months ago (2017-07-19 21:04:42 UTC) #5

Dry run: This issue passed the CQ dry run.