Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2983813002: Add hook to register global object (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
Reviewers:
Alan Knight, sra1
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add hook to register global object DDC will use this in a later CL. R=alanknight@google.com, sra@google.com Stephen: I assume this will get compiled out be dart2js. Committed: https://github.com/dart-lang/sdk/commit/12e32e230db373d66f356e16475b0f0c9d77f496

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M tools/dom/src/dart2js_DOMImplementation.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vsm
3 years, 5 months ago (2017-07-18 23:13:52 UTC) #4
Alan Knight
lgtm
3 years, 5 months ago (2017-07-18 23:21:25 UTC) #5
sra1
lgtm
3 years, 5 months ago (2017-07-19 00:02:17 UTC) #6
vsm
3 years, 5 months ago (2017-07-19 12:46:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
12e32e230db373d66f356e16475b0f0c9d77f496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698