Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2983783003: Remove the 'Move File' refactoring. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the 'Move File' refactoring. It has been broken since we switched to Analysis Driver. Given that IDEA does not use it, there is little incentive to fix it. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/90121b528aac0086d5c5fa5324044aa3aa9b2987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -528 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +0 lines, -7 lines 0 comments Download
D pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +0 lines, -242 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 3 chunks +0 lines, -27 lines 0 comments Download
D pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +0 lines, -250 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-18 21:29:14 UTC) #1
Paul Berry
lgtm
3 years, 5 months ago (2017-07-18 22:06:50 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 90121b528aac0086d5c5fa5324044aa3aa9b2987 (presubmit successful).
3 years, 5 months ago (2017-07-19 00:59:27 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-19 22:40:31 UTC) #5
Message was sent while issue was closed.
I disagree. I think the right solution is to fix it and then make IntelliJ use
it. We ought to be able to update references to files that are being moved; it's
minimal functionality for IDEs at this point in time.

Powered by Google App Engine
This is Rietveld 408576698