Issue 298373002: Follow up change for disabling out-of-box VK overscroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298373002: Follow up change for disabling out-of-box VK overscroll (Closed)

Created:
6 years, 6 months ago by Nikita (slow)

Modified:
6 years, 6 months ago

Reviewers:
ygorshenin1

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Follow up change for disabling out-of-box VK overscroll Have to use CoreOobeActor through OobeUI since WebUILoginDisplay is not created during out-of-box. Removed changes in *LoginDisplay*. BUG=363635 R=ygorshenin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273241

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -39 lines)			Patch
M	chrome/browser/chromeos/login/ui/login_display.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_display_host_impl.cc	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/mock_login_display.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/oobe_display.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/ui/webui_login_display.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Committed patchset #1 manually as r273241 (presubmit successful).

6 years, 6 months ago (2014-05-28 15:15:50 UTC) #4

tzik

6 years, 6 months ago (2014-05-29 09:34:46 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/301923002/ by tzik@chromium.org.

The reason for reverting is: This CL broke VMTest on ChromiumOS bot:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%....

Expand Messages | Collapse Messages