Avoid Bigint literals in Dart core library

Avoid Bigint literals in Dart core library

This CL is a step towards preparation of Dart core library for 64-bit
integers in Dart. In the new --limit-ints-to-64-bits mode integer
literals which are out of range will be rejected, so such literals
should not be used in the core library.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed: https://github.com/dart-lang/sdk/commit/a2388dd37005b35946699e635474583ebf4bfb1d

[alexmarkov, 2017-07-14 22:12:40]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, floitsch@google.com, lrn@google.com, regis@google.com,
zra@google.com

[zra, 2017-07-14 22:26:24]

lgtm

[alexmarkov, 2017-07-17 15:05:03]

Description was changed from

==========
Avoid Bigint literals in Dart core library

This CL is a step towards preparation of Dart core library for 64-bit
integers in Dart. In the new --limit-ints-to-64-bits mode integer
literals which are out of range will be rejected, so such literals
should not be used in the core library.

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
Avoid Bigint literals in Dart core library

This CL is a step towards preparation of Dart core library for 64-bit
integers in Dart. In the new --limit-ints-to-64-bits mode integer
literals which are out of range will be rejected, so such literals
should not be used in the core library.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed:
https://github.com/dart-lang/sdk/commit/a2388dd37005b35946699e635474583ebf4bfb1d
==========

[alexmarkov, 2017-07-17 15:05:05]

Committed patchset #1 (id:1) manually as
a2388dd37005b35946699e635474583ebf4bfb1d (presubmit successful).

[regis, 2017-07-17 16:45:32]

DBC

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:62: static const int _TWO_DIGITS_MASK = (1 <<
_TWO_DIGITS_BITS) - 1;
How is this supposed to work? Do you avoid the creation of a bigint when bigints
are disabled, because the shift will wrap around? A comment explaining these new
constants would be nice.

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/typed_data_patc...
File runtime/lib/typed_data_patch.dart (right):

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/typed_data_patc...
runtime/lib/typed_data_patch.dart:3047: const _uint64Mask = (1 << 64) - 1;
ditto

[alexmarkov, 2017-07-17 20:21:29]

Followed up in a separate CL:
https://codereview.chromium.org/2980243002/

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (right):

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/bigint.dart#new...
runtime/lib/bigint.dart:62: static const int _TWO_DIGITS_MASK = (1 <<
_TWO_DIGITS_BITS) - 1;
On 2017/07/17 16:45:31, regis wrote:
> How is this supposed to work? Do you avoid the creation of a bigint when
bigints
> are disabled, because the shift will wrap around? A comment explaining these
new
> constants would be nice.

Done.

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/typed_data_patc...
File runtime/lib/typed_data_patch.dart (right):

https://codereview.chromium.org/2983633002/diff/1/runtime/lib/typed_data_patc...
runtime/lib/typed_data_patch.dart:3047: const _uint64Mask = (1 << 64) - 1;
On 2017/07/17 16:45:31, regis wrote:
> ditto

Done.