android_webview/browser/aw_web_contents_delegate.cc - Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_web_contents_delegate.cc

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_web_contents_delegate.cc

diff --git a/android_webview/browser/aw_web_contents_delegate.cc b/android_webview/browser/aw_web_contents_delegate.cc

index e3b2d971ea6714ad31b2313c2929de78acfb6979..0512140303c2217b7d550d162d948dd859f6f3a3 100644

--- a/android_webview/browser/aw_web_contents_delegate.cc

+++ b/android_webview/browser/aw_web_contents_delegate.cc

@@ -182,8 +182,7 @@

int opener_render_frame_id,

const std::string& frame_name,

const GURL& target_url,

- content::WebContents* new_contents,

- const base::Optional<content::WebContents::CreateParams>& create_params) {

+ content::WebContents* new_contents) {

AwContentsIoThreadClient::RegisterPendingContents(new_contents);

}