extensions/browser/guest_view/web_view/web_view_guest.h - Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 54e72bdd6a9cf151b3b9514957ac15ea0165b90c..72d3fb00603f2cb23d2334e6f375e50aea0f47e2 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -15,7 +15,6 @@

#include "content/public/browser/javascript_dialog_manager.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

-#include "content/public/browser/web_contents.h"

#include "extensions/browser/guest_view/web_view/javascript_dialog_helper.h"

#include "extensions/browser/guest_view/web_view/web_view_find_helper.h"

#include "extensions/browser/guest_view/web_view/web_view_guest_delegate.h"

@@ -242,15 +241,12 @@

content::WebContents* OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) final;

- void WebContentsCreated(

- content::WebContents* source_contents,

- int opener_render_process_id,

- int opener_render_frame_id,

- const std::string& frame_name,

- const GURL& target_url,

- content::WebContents* new_contents,

- const base::Optional<content::WebContents::CreateParams>& create_params)

- final;

+ void WebContentsCreated(content::WebContents* source_contents,

+ int opener_render_process_id,

+ int opener_render_frame_id,

+ const std::string& frame_name,

+ const GURL& target_url,

+ content::WebContents* new_contents) final;

void EnterFullscreenModeForTab(content::WebContents* web_contents,

const GURL& origin) final;

void ExitFullscreenModeForTab(content::WebContents* web_contents) final;