components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index 731e90068e1faca78a80dca4b0f4d8d228fa8114..0a31742d35581a539552a32c393fd65485dc30ed 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -219,8 +219,7 @@

int opener_render_frame_id,

const std::string& frame_name,

const GURL& target_url,

- WebContents* new_contents,

- const base::Optional<content::WebContents::CreateParams>& create_params) {

+ WebContents* new_contents) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);

if (obj.is_null())