chrome/browser/page_load_metrics/metrics_web_contents_observer.h - Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

index 60ace4ec730cebd9f684c9790857f4e03fdb6e91..4f794b818a078c296bd08cc7c5a93a7189aaefc7 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

@@ -76,11 +76,9 @@

// Note that the returned metrics is owned by the web contents.

static MetricsWebContentsObserver* CreateForWebContents(

content::WebContents* web_contents,

- const base::Optional<content::WebContents::CreateParams>& create_params,

std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface);

MetricsWebContentsObserver(

content::WebContents* web_contents,

- const base::Optional<content::WebContents::CreateParams>& create_params,

std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface);

~MetricsWebContentsObserver() override;