Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index b565c76b692dac679d9177c88e56a2c187d523f0..ff3f0271150f5c9890957c179e7f8decdbbc0803 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -138,9 +138,7 @@
} // namespace
// static
-void TabHelpers::AttachTabHelpers(
- WebContents* web_contents,
- const base::Optional<WebContents::CreateParams>& create_params) {
+void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
// If already adopted, nothing to be done.
base::SupportsUserData::Data* adoption_tag =
web_contents->GetUserData(&kTabContentsAttachedTabHelpersUserDataKey);
@@ -204,7 +202,7 @@
MixedContentSettingsTabHelper::CreateForWebContents(web_contents);
NavigationCorrectionTabObserver::CreateForWebContents(web_contents);
NavigationMetricsRecorder::CreateForWebContents(web_contents);
- chrome::InitializePageLoadMetricsForWebContents(web_contents, create_params);
+ chrome::InitializePageLoadMetricsForWebContents(web_contents);
PermissionRequestManager::CreateForWebContents(web_contents);
PopupBlockerTabHelper::CreateForWebContents(web_contents);
PrefsTabHelper::CreateForWebContents(web_contents);
« no previous file with comments | « chrome/browser/ui/tab_helpers.h ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698