chrome/browser/android/tab_web_contents_delegate_android.cc - Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc

index 7bea27a4b5ad2f2adbab1b85069adc6f000dbb28..3b2312ad5fadcf10e1f15244479ea9329ceee159 100644

--- a/chrome/browser/android/tab_web_contents_delegate_android.cc

+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc

@@ -389,7 +389,7 @@

// Can't create a new contents for the current tab - invalid case.

DCHECK_NE(disposition, WindowOpenDisposition::CURRENT_TAB);

- TabHelpers::AttachTabHelpers(new_contents, base::nullopt);

+ TabHelpers::AttachTabHelpers(new_contents);

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);

« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/devtools/devtools_window.h » ('j') | no next file with comments »